net/spdy/spdy_frame_builder.cc - Issue 910393003: Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_builder.cc

Issue 910393003: Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_frame_builder.cc

diff --git a/net/spdy/spdy_frame_builder.cc b/net/spdy/spdy_frame_builder.cc

index 0b852118d11c4519acdd3ffa094755be4bd960b5..1e16abde9b8d8ec29b6e736f7859f1d49e884328 100644

--- a/net/spdy/spdy_frame_builder.cc

+++ b/net/spdy/spdy_frame_builder.cc

@@ -130,7 +130,7 @@ bool SpdyFrameBuilder::BeginNewFrame(const SpdyFramer& framer,

return success;

}

-bool SpdyFrameBuilder::WriteString(const std::string& value) {

+bool SpdyFrameBuilder::WriteStringPiece16(const base::StringPiece& value) {

if (value.size() > 0xffff) {

DCHECK(false) << "Tried to write string with length > 16bit.";

return false;

« no previous file with comments | « net/spdy/spdy_frame_builder.h ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »