content/browser/android/overscroll_controller_android.cc - Issue 910373002: [Android] Disable pull-to-refresh with overflow:hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/overscroll_controller_android.cc

Issue 910373002: [Android] Disable pull-to-refresh with overflow:hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/android/overscroll_controller_android.cc

diff --git a/content/browser/android/overscroll_controller_android.cc b/content/browser/android/overscroll_controller_android.cc

index 68c2006f32ab0ea7d3926118fe93663b595f12d9..9091393eb0dbcf9be3d0de075205dc6a0b2f33e9 100644

--- a/content/browser/android/overscroll_controller_android.cc

+++ b/content/browser/android/overscroll_controller_android.cc

@@ -252,8 +252,10 @@ void OverscrollControllerAndroid::OnFrameMetadataUpdated(

gfx::Vector2dF content_scroll_offset =

gfx::ScaleVector2d(frame_metadata.root_scroll_offset, scale_factor);

- if (refresh_effect_)

- refresh_effect_->UpdateDisplay(viewport_size, content_scroll_offset);

+ if (refresh_effect_) {

+ refresh_effect_->UpdateDisplay(viewport_size, content_scroll_offset,

+ frame_metadata.root_overflow_y_hidden);

+ }

if (glow_effect_) {

glow_effect_->UpdateDisplay(viewport_size, content_size,

« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | content/browser/android/overscroll_refresh.h » ('j') | no next file with comments »