Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/proxy/proxy_resolver_mojo_unittest.cc

Issue 910343003: Create an in-process v8 proxy resolver using Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-complete-patch
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_browser.gypi ('K') | « net/proxy/mojo_proxy_resolver_factory.h ('k') | net/proxy/proxy_service_mojo.h » ('j') | net/proxy/proxy_service_mojo.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_mojo_unittest.cc
diff --git a/net/proxy/proxy_resolver_mojo_unittest.cc b/net/proxy/proxy_resolver_mojo_unittest.cc
index f19d824f1dfba253e99f48f10401097caa306860..b3c51afc6d98291ceb2972eafa773072ba25098a 100644
--- a/net/proxy/proxy_resolver_mojo_unittest.cc
+++ b/net/proxy/proxy_resolver_mojo_unittest.cc
@@ -171,7 +171,7 @@ void MockMojoProxyResolver::GetProxyForUrl(
class TestMojoProxyResolverFactory : public MojoProxyResolverFactory {
public:
TestMojoProxyResolverFactory();
- ~TestMojoProxyResolverFactory();
+ ~TestMojoProxyResolverFactory() override;
// Overridden from MojoProxyResolverFactory:
void Create(mojo::InterfaceRequest<interfaces::ProxyResolver> req,
« chrome/chrome_browser.gypi ('K') | « net/proxy/mojo_proxy_resolver_factory.h ('k') | net/proxy/proxy_service_mojo.h » ('j') | net/proxy/proxy_service_mojo.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698