Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: net/BUILD.gn

Issue 910343003: Create an in-process v8 proxy resolver using Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-complete-patch
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index d7a6abf17f469f88459849b9cb6bb9047472c9d3..0c8720f53273767a6579103dc3529992c6917e59 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -794,9 +794,13 @@ if (use_v8_in_net && !is_android) {
sources = [
"dns/mojo_host_resolver_impl.cc",
"dns/mojo_host_resolver_impl.h",
+ "proxy/in_process_mojo_proxy_resolver_factory.cc",
+ "proxy/in_process_mojo_proxy_resolver_factory.h",
"proxy/mojo_proxy_resolver_factory.h",
"proxy/proxy_resolver_mojo.cc",
"proxy/proxy_resolver_mojo.h",
+ "proxy/proxy_service_mojo.cc",
+ "proxy/proxy_service_mojo.h",
]
public_deps = [
@@ -805,6 +809,12 @@ if (use_v8_in_net && !is_android) {
"//base",
"//net/interfaces",
"//third_party/mojo/src/mojo/public/cpp/bindings",
+
+ # NOTE(amistry): As long as we support in-process Mojo v8 PAC, we need
+ # this dependency since in_process_mojo_proxy_resolver_factory creates
+ # the utility process side Mojo services in the browser process.
+ # Ultimately, this will go away when we only support out-of-process.
+ ":net_utility_services",
]
}
@@ -1405,6 +1415,7 @@ if (!is_android && !is_win && !is_mac) {
"proxy/mojo_proxy_resolver_factory_impl_unittest.cc",
"proxy/mojo_proxy_resolver_impl_unittest.cc",
"proxy/proxy_resolver_mojo_unittest.cc",
+ "proxy/proxy_service_mojo_unittest.cc",
]
}

Powered by Google App Engine
This is Rietveld 408576698