chrome/browser/BUILD.gn - Issue 910343003: Create an in-process v8 proxy resolver using Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 910343003: Create an in-process v8 proxy resolver using Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-complete-patch

Patch Set: Address review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 975c68cf180d4b74143c51ef71e448187579b930..9d04555500b87eb2b0d7f876d4b9a1c73b476a4c 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -294,6 +294,9 @@ static_library("browser") {

sources +=

rebase_path(gypi_values.chrome_browser_win_mac_sources, ".", "//chrome")

}

+ if (!is_android && !is_ios) {

+ deps += [ "//net:net_browser_services" ]

Lei Zhang 2015/03/02 20:08:08 You can put this with line 390.

Anand Mistry (off Chromium) 2015/03/03 02:54:42 Done.

+ }

if (!is_android && !is_ios && !is_chromeos && enable_configuration_policy) {

sources += [

"net/disk_cache_dir_policy_handler.cc",

« no previous file with comments | « no previous file | chrome/browser/net/proxy_service_factory.cc » ('j') | chrome/chrome_browser.gypi » ('J')