Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910343003: Create an in-process v8 proxy resolver using Mojo. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-pac-complete-patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create an in-process v8 proxy resolver using Mojo. This in-process mode will only be used for testing and debugging, and is intentionally not exposed via about:flags. BUG=11746 Committed: https://crrev.com/6e1ed1ba34bf761fc17c111287b8828f2f409f6c Cr-Commit-Position: refs/heads/master@{#320236}

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : Rebase and update. #

Patch Set 4 : Rebase #

Patch Set 5 : Cleanup and fixes. #

Patch Set 6 : Flag. #

Total comments: 12

Patch Set 7 : Rebase #

Patch Set 8 : Address review comments. #

Total comments: 6

Patch Set 9 : Review comments #

Patch Set 10 : Rebase #

Patch Set 11 : Fix android build. #

Patch Set 12 : Rebase #

Patch Set 13 : Linter fix. #

Patch Set 14 : Rebase #

Total comments: 2

Patch Set 15 : Rebase. #

Patch Set 16 : Remove extra space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -17 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +19 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +11 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +12 lines, -0 lines 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
A net/proxy/in_process_mojo_proxy_resolver_factory.h View 1 2 3 4 5 6 7 1 chunk +39 lines, -0 lines 0 comments Download
A net/proxy/in_process_mojo_proxy_resolver_factory.cc View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_mojo_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
A + net/proxy/proxy_service_mojo.h View 3 chunks +21 lines, -8 lines 0 comments Download
A net/proxy/proxy_service_mojo.cc View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A net/proxy/proxy_service_mojo_unittest.cc View 1 2 3 4 5 6 7 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Anand Mistry (off Chromium)
eroman@chromium.org: Please review changes in net/ and proxy_service_factory.cc thestig@chromium.org: Please review changes in chrome/
5 years, 10 months ago (2015-02-25 07:20:27 UTC) #2
Sam McNally
https://codereview.chromium.org/910343003/diff/100001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/910343003/diff/100001/net/BUILD.gn#newcode1417 net/BUILD.gn:1417: "proxy/mojo_proxy_service_unittest.cc", proxy_service_mojo_unittest.cc https://codereview.chromium.org/910343003/diff/100001/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/910343003/diff/100001/net/net.gyp#newcode723 net/net.gyp:723: 'proxy/mojo_proxy_service_unittest.cc', ...
5 years, 10 months ago (2015-02-26 06:36:41 UTC) #3
Anand Mistry (off Chromium)
https://codereview.chromium.org/910343003/diff/100001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/910343003/diff/100001/net/BUILD.gn#newcode1417 net/BUILD.gn:1417: "proxy/mojo_proxy_service_unittest.cc", On 2015/02/26 06:36:40, Sam McNally wrote: > proxy_service_mojo_unittest.cc ...
5 years, 10 months ago (2015-02-27 03:00:58 UTC) #4
Sam McNally
LGTM https://codereview.chromium.org/910343003/diff/140001/net/proxy/proxy_service_mojo.cc File net/proxy/proxy_service_mojo.cc (right): https://codereview.chromium.org/910343003/diff/140001/net/proxy/proxy_service_mojo.cc#newcode18 net/proxy/proxy_service_mojo.cc:18: // static These aren't really static.
5 years, 9 months ago (2015-03-02 03:26:24 UTC) #5
Lei Zhang
chrome/ lgtm with a couple nits. https://codereview.chromium.org/910343003/diff/140001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/910343003/diff/140001/chrome/browser/BUILD.gn#newcode298 chrome/browser/BUILD.gn:298: deps += [ ...
5 years, 9 months ago (2015-03-02 20:08:08 UTC) #6
Anand Mistry (off Chromium)
Eric: Some of the //net changes are from https://codereview.chromium.org/917863005/ which should be reviewed first. https://codereview.chromium.org/910343003/diff/140001/chrome/browser/BUILD.gn ...
5 years, 9 months ago (2015-03-03 02:54:43 UTC) #7
Anand Mistry (off Chromium)
Ping!
5 years, 9 months ago (2015-03-11 03:06:19 UTC) #8
eroman
lgtm https://codereview.chromium.org/910343003/diff/260001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/910343003/diff/260001/net/BUILD.gn#newcode963 net/BUILD.gn:963: extra space added
5 years, 9 months ago (2015-03-11 21:08:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910343003/300001
5 years, 9 months ago (2015-03-12 04:18:41 UTC) #12
Anand Mistry (off Chromium)
https://codereview.chromium.org/910343003/diff/260001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/910343003/diff/260001/net/BUILD.gn#newcode963 net/BUILD.gn:963: On 2015/03/11 21:08:19, eroman wrote: > extra space added ...
5 years, 9 months ago (2015-03-12 04:51:42 UTC) #13
commit-bot: I haz the power
Committed patchset #16 (id:300001)
5 years, 9 months ago (2015-03-12 05:24:13 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 05:24:49 UTC) #15
Message was sent while issue was closed. 
Patchset 16 (id:??) landed as
https://crrev.com/6e1ed1ba34bf761fc17c111287b8828f2f409f6c
Cr-Commit-Position: refs/heads/master@{#320236}

Powered by Google App Engine
This is Rietveld 408576698