Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910343002: Decompose VideoRenderer from VideoStub. (Closed)

Created:
5 years, 10 months ago by Wez
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decompose VideoRenderer from VideoStub. Switch from inheritance to composition, to allow implementations to be more modular. Committed: https://crrev.com/d97a44290b2134a57b76e74c374587e3bd4072bb Cr-Commit-Position: refs/heads/master@{#316360}

Patch Set 1 #

Patch Set 2 : Remove unrelated diff :) #

Total comments: 1

Patch Set 3 : Add missing dtor and GetVideoStub() impl #

Patch Set 4 : Fix perf test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M remoting/client/chromoting_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.h View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_2d.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.h View 3 chunks +8 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_video_renderer_3d.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/client/software_video_renderer.h View 3 chunks +6 lines, -1 line 0 comments Download
M remoting/client/software_video_renderer.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/client/video_renderer.h View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Wez
WDYT?
5 years, 10 months ago (2015-02-11 19:58:27 UTC) #2
Sergey Ulanov
I think it's a good idea. https://codereview.chromium.org/910343002/diff/20001/remoting/client/software_video_renderer.h File remoting/client/software_video_renderer.h (right): https://codereview.chromium.org/910343002/diff/20001/remoting/client/software_video_renderer.h#newcode49 remoting/client/software_video_renderer.h:49: protocol::VideoStub* GetVideoStub() override; ...
5 years, 10 months ago (2015-02-11 21:54:53 UTC) #3
Wez
On 2015/02/11 21:54:53, Sergey Ulanov wrote: > I think it's a good idea. > > ...
5 years, 10 months ago (2015-02-14 00:24:47 UTC) #4
Sergey Ulanov
lgtm
5 years, 10 months ago (2015-02-14 01:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910343002/60001
5 years, 10 months ago (2015-02-14 01:56:21 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-14 02:00:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 02:01:20 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d97a44290b2134a57b76e74c374587e3bd4072bb
Cr-Commit-Position: refs/heads/master@{#316360}

Powered by Google App Engine
This is Rietveld 408576698