Source/web/tests/WebFrameTest.cpp - Issue 910313004: Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 910313004: Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address Daniel's comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 10f14462c431349224cfd23efe19d3651ba66e99..5882059e7a41755b8f144dafc96dc4ca38c31e45 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -6896,7 +6896,7 @@ TEST_F(WebFrameSwapTest, SwapParentShouldDetachChildren)

// Create child frames in the target frame before testing the swap.

FrameTestHelpers::TestWebRemoteFrameClient remoteFrameClient;

- remoteFrame->createRemoteChild("", &remoteFrameClient);

+ remoteFrame->createRemoteChild("", WebSandboxFlags::None, &remoteFrameClient);

FrameTestHelpers::TestWebFrameClient client;

WebFrame* localFrame = WebLocalFrame::create(&client);

« Source/web/RemoteBridgeFrameOwner.h ('K') | « Source/web/WebRemoteFrameImpl.cpp ('k') | Source/web/web.gypi » ('j') | no next file with comments »