Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 910313003: Rewrite fast/multicol/shadow-breaking.html as a check-layout test. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rewrite fast/multicol/shadow-breaking.html as a check-layout test. The old / current multicol implementation had imperfect column balancing in the old test, so writing a reftest would be tricky, but anyway: it's not obvious that our current behavior (both implementations) where we include the shadows in the columns, rather than letting them overflow, is correct (as a matter of fact, it's most likely wrong). So let's just test what really needs to work: that a shadow doesn't incorrectly push the next line down. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -228 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/shadow-breaking.html View 1 chunk +10 lines, -36 lines 0 comments Download
A LayoutTests/fast/multicol/shadow-breaking-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/shadow-breaking-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/shadow-breaking-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/shadow-breaking-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/shadow-breaking-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/shadow-breaking-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/shadow-breaking-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-11 14:10:55 UTC) #1
andersr
lgtm
5 years, 10 months ago (2015-02-12 22:07:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910313003/1
5 years, 10 months ago (2015-02-12 22:22:35 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 22:27:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190085

Powered by Google App Engine
This is Rietveld 408576698