Issue 910283002: Switch font embedding to a compile-time flag, with a todo for runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 910283002: Switch font embedding to a compile-time flag, with a todo for runtime. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Switch font embedding to a compile-time flag, with a todo for runtime. BUG=skia:3417 Committed: https://skia.googlesource.com/skia/+/d9591bb98c04aa6d66147d3776a8e4a7b0332771

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkPictureData.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

reed1

lets make the associated change in chrome's skia/config/SkUserConfig.h as well. lgtm

5 years, 10 months ago (2015-02-10 19:41:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910283002/1

5 years, 10 months ago (2015-02-10 19:42:30 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 19:49:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9591bb98c04aa6d66147d3776a8e4a7b0332771