Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 910283002: Switch font embedding to a compile-time flag, with a todo for runtime. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch font embedding to a compile-time flag, with a todo for runtime. BUG=skia:3417 Committed: https://skia.googlesource.com/skia/+/d9591bb98c04aa6d66147d3776a8e4a7b0332771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkPictureData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 10 months ago (2015-02-10 19:37:48 UTC) #2
reed1
lets make the associated change in chrome's skia/config/SkUserConfig.h as well. lgtm
5 years, 10 months ago (2015-02-10 19:41:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910283002/1
5 years, 10 months ago (2015-02-10 19:42:30 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:49:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9591bb98c04aa6d66147d3776a8e4a7b0332771

Powered by Google App Engine
This is Rietveld 408576698