Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/bin/secure_socket.cc

Issue 910183003: Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/secure_socket.cc
diff --git a/runtime/bin/secure_socket.cc b/runtime/bin/secure_socket.cc
index 2e22fef31edcffd635810cafe51cb9814534b85c..63f600ff7915027afb7974ae80279568d4db5b03 100644
--- a/runtime/bin/secure_socket.cc
+++ b/runtime/bin/secure_socket.cc
@@ -150,7 +150,7 @@ void FUNCTION_NAME(SecureSocket_Connect)(Dart_NativeArguments args) {
ASSERT(!Dart_IsNull(protocols_handle));
GetFilter(args)->Connect(host_name,
- &raw_addr,
+ raw_addr,
static_cast<int>(port),
is_server,
certificate_name,
@@ -666,7 +666,7 @@ Dart_Handle SSLFilter::PeerCertificate() {
void SSLFilter::Connect(const char* host_name,
- RawAddr* raw_addr,
+ const RawAddr& raw_addr,
int port,
bool is_server,
const char* certificate_name,
@@ -835,13 +835,13 @@ void SSLFilter::Connect(const char* host_name,
memset(&peername, 0, sizeof(peername));
intptr_t len = SocketAddress::GetAddrLength(raw_addr);
ASSERT(static_cast<size_t>(len) <= sizeof(peername));
- memmove(&peername, &raw_addr->addr, len);
+ memmove(&peername, &raw_addr.addr, len);
// Adjust the address family field for BSD, whose sockaddr
// structure has a one-byte length and one-byte address family
// field at the beginning. PRNetAddr has a two-byte address
// family field at the beginning.
- peername.raw.family = raw_addr->addr.sa_family;
+ peername.raw.family = raw_addr.addr.sa_family;
memio_SetPeerName(filter_, &peername);
}
« no previous file with comments | « runtime/bin/secure_socket.h ('k') | runtime/bin/socket.h » ('j') | runtime/bin/socket.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698