Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code

runtime/bin/secure_socket.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/secure_socket.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <stdio.h>
@@ skipping 132 matching lines @@
                                       &certificate_name));
   }
   // If this is a server connection, it must have a certificate to connect with.
   ASSERT(!is_server || certificate_name != NULL);
 
   // The protocols_handle is guaranteed to be a valid Uint8List.
   // It will have the correct length encoding of the protocols array.
   ASSERT(!Dart_IsNull(protocols_handle));
 
   GetFilter(args)->Connect(host_name,
-                           &raw_addr,
+                           raw_addr,
                            static_cast<int>(port),
                            is_server,
                            certificate_name,
                            request_client_certificate,
                            require_client_certificate,
                            send_client_certificate,
                            protocols_handle);
 }
 
 
@@ skipping 495 matching lines @@
 Dart_Handle SSLFilter::PeerCertificate() {
   CERTCertificate* certificate = SSL_PeerCertificate(filter_);
   if (certificate == NULL) return Dart_Null();
   Dart_Handle x509_object = X509FromCertificate(certificate);
   CERT_DestroyCertificate(certificate);
   return x509_object;
 }
 
 
 void SSLFilter::Connect(const char* host_name,
-                        RawAddr* raw_addr,
+                        const RawAddr& raw_addr,
                         int port,
                         bool is_server,
                         const char* certificate_name,
                         bool request_client_certificate,
                         bool require_client_certificate,
                         bool send_client_certificate,
                         Dart_Handle protocols_handle) {
   is_server_ = is_server;
   if (in_handshake_) {
     FATAL("Connect called twice on the same _SecureFilter.");
@@ skipping 148 matching lines @@
 
   // Set the peer address from the address passed. The DNS has already
   // been done in Dart code, so just use that address. This relies on
   // following about PRNetAddr: "The raw member of the union is
   // equivalent to struct sockaddr", which is stated in the NSS
   // documentation.
   PRNetAddr peername;
   memset(&peername, 0, sizeof(peername));
   intptr_t len = SocketAddress::GetAddrLength(raw_addr);
   ASSERT(static_cast<size_t>(len) <= sizeof(peername));
-  memmove(&peername, &raw_addr->addr, len);
+  memmove(&peername, &raw_addr.addr, len);
 
   // Adjust the address family field for BSD, whose sockaddr
   // structure has a one-byte length and one-byte address family
   // field at the beginning.  PRNetAddr has a two-byte address
   // family field at the beginning.
-  peername.raw.family = raw_addr->addr.sa_family;
+  peername.raw.family = raw_addr.addr.sa_family;
 
   memio_SetPeerName(filter_, &peername);
 }
 
 
 void SSLFilter::Handshake() {
   SECStatus status = SSL_ForceHandshake(filter_);
   if (status == SECSuccess) {
     if (in_handshake_) {
       ThrowIfError(Dart_InvokeClosure(
@@ skipping 198 matching lines @@
     }
     if (bytes_processed > 0) {
       memio_PutWriteResult(secret, bytes_processed);
     }
   }
   return bytes_processed;
 }
 
 }  // namespace bin
 }  // namespace dart