Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 910143003: Change in android Java build rules for Mojo Java content handler (Closed)

Created:
5 years, 10 months ago by etiennej
Modified:
5 years, 10 months ago
Reviewers:
cjhopman, qsr
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change in android Java build rules for Mojo Java content handler See https://codereview.chromium.org/898853006 for motivation Committed: https://crrev.com/32a8a141c605f608f158801ea863784683e4dd2f Cr-Commit-Position: refs/heads/master@{#315959}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M build/android/gyp/javac.py View 4 chunks +17 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +10 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
etiennej
5 years, 10 months ago (2015-02-10 13:29:42 UTC) #3
qsr
LGTM, but I'm not an OWNER of this code. +cjhopman@chromium.org
5 years, 10 months ago (2015-02-10 13:31:27 UTC) #5
cjhopman
lgtm
5 years, 10 months ago (2015-02-11 18:17:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910143003/20001
5 years, 10 months ago (2015-02-12 09:23:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-12 11:29:39 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 11:30:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32a8a141c605f608f158801ea863784683e4dd2f
Cr-Commit-Position: refs/heads/master@{#315959}

Powered by Google App Engine
This is Rietveld 408576698