Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 910093002: telemetry: Add python mock library. (Closed)

Created:
5 years, 10 months ago by erikchen
Modified:
5 years, 10 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry: Add python mock library. This is the mock library used by ChromeOS, and it comes bundled with Python 3.3+. BUG= Committed: https://crrev.com/bf655124b7ec1836216411173f6c329b0ed1935f Cr-Commit-Position: refs/heads/master@{#315653}

Patch Set 1 : Removed unnecessary files. #

Total comments: 2

Patch Set 2 : Comment from dtu. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, --2 lines) Patch
A + tools/telemetry/third_party/mock/LICENSE.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/mock/README.chromium View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/mock/mock.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
erikchen
nednguyen: Please review.
5 years, 10 months ago (2015-02-10 00:23:52 UTC) #3
nednguyen
+Dave: is this the right way to add third party library? Erik is adding mock ...
5 years, 10 months ago (2015-02-10 00:30:51 UTC) #5
sullivan
On 2015/02/10 00:30:51, nednguyen wrote: > +Dave: is this the right way to add third ...
5 years, 10 months ago (2015-02-10 14:58:59 UTC) #6
dtu
On 2015/02/10 14:58:59, sullivan wrote: > On 2015/02/10 00:30:51, nednguyen wrote: > > +Dave: is ...
5 years, 10 months ago (2015-02-10 20:54:27 UTC) #7
dtu
https://codereview.chromium.org/910093002/diff/10001/tools/telemetry/third_party/mock/README.chromium File tools/telemetry/third_party/mock/README.chromium (right): https://codereview.chromium.org/910093002/diff/10001/tools/telemetry/third_party/mock/README.chromium#newcode5 tools/telemetry/third_party/mock/README.chromium:5: Date: 2015-02-09 This is the date the package was ...
5 years, 10 months ago (2015-02-10 20:54:33 UTC) #8
erikchen
https://codereview.chromium.org/910093002/diff/10001/tools/telemetry/third_party/mock/README.chromium File tools/telemetry/third_party/mock/README.chromium (right): https://codereview.chromium.org/910093002/diff/10001/tools/telemetry/third_party/mock/README.chromium#newcode5 tools/telemetry/third_party/mock/README.chromium:5: Date: 2015-02-09 On 2015/02/10 20:54:33, dtu wrote: > This ...
5 years, 10 months ago (2015-02-10 21:03:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910093002/30001
5 years, 10 months ago (2015-02-10 21:04:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:30001)
5 years, 10 months ago (2015-02-10 22:00:22 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 22:01:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf655124b7ec1836216411173f6c329b0ed1935f
Cr-Commit-Position: refs/heads/master@{#315653}

Powered by Google App Engine
This is Rietveld 408576698