extensions/common/guest_view/guest_view_constants.cc - Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/guest_view/guest_view_constants.cc

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/guest_view/guest_view_constants.h ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/guest_view/guest_view_constants.cc

diff --git a/extensions/common/guest_view/guest_view_constants.cc b/extensions/common/guest_view/guest_view_constants.cc

index f478c64a33ee3c7bd883b7d56ef66da2d87335a1..94af1b5eceac77315e3056903ea1ee528696aa23 100644

--- a/extensions/common/guest_view/guest_view_constants.cc

+++ b/extensions/common/guest_view/guest_view_constants.cc

@@ -20,6 +20,8 @@ const char kElementSizeIsLogical[] = "elementSizeIsLogical";

const char kEventResize[] = "guestViewInternal.onResize";

// Parameters/properties on events.

+const char kContentWindowID[] = "contentWindowId";

+const char kID[] = "id";

const char kIsTopLevel[] = "isTopLevel";

const char kNewWidth[] = "newWidth";

const char kNewHeight[] = "newHeight";