chrome/test/data/extensions/platform_apps/web_view/shim/main.js - Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/inject_comm_channel.js ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js

index 9f06f185aa3f2af9d886b9d88c7e4d8854d359a5..91a9d8103d30ed0c8b77fe3bf6869104d942fcec 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js

@@ -1738,8 +1738,11 @@ function testResizeWebviewWithDisplayNoneResizesContent() {

function testPostMessageCommChannel() {

var webview = new WebView();

+ // Run this test with display:none to verify that postMessage works correctly.

+ webview.style.display = 'none';

webview.src = 'about:blank';

webview.addEventListener('loadstop', function(e) {

+ window.console.log('loadstop');

webview.executeScript(

{file: 'inject_comm_channel.js'},

function(results) {

@@ -1751,6 +1754,9 @@ function testPostMessageCommChannel() {

}

);

});

+ webview.addEventListener('consolemessage', function(e) {

+ window.console.log('Guest: "' + e.message + '"');

+ });

window.addEventListener('message', function(e) {

var data = JSON.parse(e.data);

if (data[0] == 'connected') {