<webview>: Make contentWindow available prior to attachment (on display:none).

content/public/browser/browser_plugin_guest_delegate.h

Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 3cb9270fac9c598e45088a502eb925cbdb60997c..8ad7c764ce9ac451d7a81c655298351512dca106 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -8,7 +8,6 @@
 #include "base/callback_forward.h"
 #include "base/process/kill.h"
 #include "content/common/content_export.h"
-#include "content/public/browser/guest_sizer.h"
 #include "content/public/browser/web_contents.h"
 
 namespace base {
@@ -21,6 +20,8 @@ class Size;
 
 namespace content {
 
+class GuestProxyHost;
+
 // Objects implement this interface to get notified about changes in the guest
 // WebContents and to provide necessary functionality.
 class CONTENT_EXPORT BrowserPluginGuestDelegate {
@@ -43,9 +44,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
   // of as workers with a DOM.
   virtual bool CanRunInDetachedState() const;
 
-  // Notification that the embedder has completed attachment. The
-  // |guest_proxy_routing_id| is the routing ID for the RenderView in the
-  // embedder that will serve as a contentWindow proxy for the guest.

[Charlie Reis, 2015/03/09 18:52:59]

Why delete this comment?

I agree it would be nice not to have to expose a proxy's routing ID, but the
parameter is still there and should be documented.

[Fady Samuel, 2015/03/09 23:02:41]

Done.

+  // Notification that the embedder has completed attachment.
   virtual void DidAttach(int guest_proxy_routing_id) {}
 
   // Notification that the guest has detached from its container.
@@ -72,12 +71,6 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
       bool last_unlocked_by_target,
       const base::Callback<void(bool)>& callback) {}
 
-  // Registers a |callback| with the delegate that the delegate would call when
-  // it is about to be destroyed.
-  typedef base::Callback<void()> DestructionCallback;
-  virtual void RegisterDestructionCallback(
-      const DestructionCallback& callback) {}
-
   // Find the given |search_text| in the page. Returns true if the find request
   // is handled by this browser plugin guest delegate.
   virtual bool Find(int request_id,
@@ -86,7 +79,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
   virtual bool StopFinding(StopFindAction action);
 
   // Provides the delegate with an interface with which to size the guest.

[Charlie Reis, 2015/03/09 18:52:58]

nit: Update comment.

[Fady Samuel, 2015/03/09 23:02:41]

Done.

-  virtual void SetGuestSizer(GuestSizer* guest_sizer) {}
+  virtual void SetGuestProxyHost(GuestProxyHost* guest_proxy_host) {}
 };
 
 }  // namespace content