Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 3cb9270fac9c598e45088a502eb925cbdb60997c..056d074e88fe6f1bbe620193251cfb88b9512794 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -8,7 +8,6 @@
#include "base/callback_forward.h"
#include "base/process/kill.h"
#include "content/common/content_export.h"
-#include "content/public/browser/guest_sizer.h"
#include "content/public/browser/web_contents.h"
namespace base {
@@ -21,6 +20,8 @@ class Size;
namespace content {
+class GuestProxyHost;
+
// Objects implement this interface to get notified about changes in the guest
// WebContents and to provide necessary functionality.
class CONTENT_EXPORT BrowserPluginGuestDelegate {
@@ -43,10 +44,8 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// of as workers with a DOM.
virtual bool CanRunInDetachedState() const;
- // Notification that the embedder has completed attachment. The
- // |guest_proxy_routing_id| is the routing ID for the RenderView in the
- // embedder that will serve as a contentWindow proxy for the guest.
- virtual void DidAttach(int guest_proxy_routing_id) {}
+ // Notification that the embedder has completed attachment.
+ virtual void DidAttach() {}
// Notification that the guest has detached from its container.
virtual void DidDetach() {}
@@ -72,12 +71,6 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) {}
- // Registers a |callback| with the delegate that the delegate would call when
- // it is about to be destroyed.
- typedef base::Callback<void()> DestructionCallback;
- virtual void RegisterDestructionCallback(
- const DestructionCallback& callback) {}
-
// Find the given |search_text| in the page. Returns true if the find request
// is handled by this browser plugin guest delegate.
virtual bool Find(int request_id,
@@ -86,7 +79,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
virtual bool StopFinding(StopFindAction action);
// Provides the delegate with an interface with which to size the guest.
- virtual void SetGuestSizer(GuestSizer* guest_sizer) {}
+ virtual void SetGuestProxyHost(GuestProxyHost* guest_proxy_host) {}
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698