<webview>: Make contentWindow available prior to attachment (on display:none).

content/public/browser/guest_proxy_host.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_GUEST_PROXY_HOST_H_
+#define CONTENT_PUBLIC_BROWSER_GUEST_PROXY_HOST_H_
+
+#include "ui/gfx/geometry/size.h"
+
+namespace content {
+
+// A GuestProxyHost is a content API for guest renderers. Guests are top-level

[Charlie Reis, 2015/03/09 18:52:59]

nit: renderer == process.  Do you mean "guests in the renderer process?"

[Fady Samuel, 2015/03/09 23:02:41]

guest WebContents, really. Updated.

+// frames that can be embedded within other pages. The content module manages
+// routing of input events and compositing, but all other operations are managed
+// outside of content. To limit exposure of implementation details within
+// content, content embedders must use this interface for loading, sizing,and

[Charlie Reis, 2015/03/09 18:52:59]

nit: space after comma

[Fady Samuel, 2015/03/09 23:02:41]

Done.

+// cleanup of guests.
+// This class currently only serves as a base class for BrowserPluginGuest, and

[Charlie Reis, 2015/03/09 18:52:59]

nit: Line break (//\n) between paragraphs).

[Fady Samuel, 2015/03/09 23:02:41]

Done.

+// its API can only be accessed by a BrowserPluginGuestDelegate.
+class GuestProxyHost {

[Charlie Reis, 2015/03/09 21:25:22]

I feel like GuestHost might be a better name for this, at least until we have
more of a resolution of how this will look after it moves to OOPIF code.  Right
now, you mentioned that BrowserPluginGuest handles messages from both the
embedder and guest, and this name is currently confusingly similar to
RenderFrameProxyHost.

In general, the FooHost naming scheme should be reserved for Foo/FooHost pairs
of routable C++ objects, but I don't have a better suggestion until we know how
things will look after the OOPIF migration.

[Fady Samuel, 2015/03/09 23:02:41]

Done.

+ public:
+  // Loads a URL using the specified |load_params| and returns a routing ID to
+  // a proxy to the guest window created.

[Charlie Reis, 2015/03/09 18:52:59]

nit: a routing ID for a proxy for the guest.

Don't mention window (confusing) or created (might have already been created).

[Fady Samuel, 2015/03/09 23:02:41]

Done.

+  virtual int LoadURLWithParams(

[Charlie Reis, 2015/03/09 18:52:59]

Do we actually need the return value?  (See my comments in
guest_view_base.{h,cc}.)

[Charlie Reis, 2015/03/09 21:25:22]

Disregard.  Only makes sense in Option 2.

[Fady Samuel, 2015/03/09 23:02:41]

Marking done twice so I know I've done what needs doing here (nothing).

[Fady Samuel, 2015/03/09 23:02:41]

Marking done twice so I know I've done what needs doing here (nothing).

+      const NavigationController::LoadURLParams& load_params) = 0;
+
+  // Sets the size of the guest WebContents.
+  virtual void SizeContents(const gfx::Size& new_size) = 0;
+
+  // Called when the GuestProxyHost is about to be destroyed.
+  virtual void WillDestroy() = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_GUEST_PROXY_HOST_H_