<webview>: Make contentWindow available prior to attachment (on display:none).

extensions/renderer/resources/guest_view/guest_view.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements a wrapper for a guestview that manages its
 // creation, attaching, and destruction.
 
 var EventBindings = require('event_bindings');
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
@@ skipping 128 matching lines @@
   // Check the current state.
   if (!this.checkState('attach')) {
     this.handleCallback(callback);
     return;
   }
 
   // Callback wrapper function to store the contentWindow from the attachGuest()
   // callback, handle potential attaching failure, register an automatic detach,
   // and advance the queue.
   var callbackWrapper = function(callback, contentWindow) {
     this.contentWindow = contentWindow;

[lfg, 2015/03/04 19:10:20]

Since the contentWindow is already assigned in create, can't we just remove it
from this callback?

[Fady Samuel, 2015/03/05 20:56:23]

No, not all GuestView types get a contentWindow on create.

 
     // Check if attaching failed.
     if (this.contentWindow === null) {
       this.state = GUEST_STATE_CREATED;
     } else {
       // Detach automatically when the container is destroyed.
       GuestViewInternalNatives.RegisterDestructionCallback(internalInstanceId,
                                                            function() {
         if (this.state == GUEST_STATE_ATTACHED) {
-          this.contentWindow = null;
           this.internalInstanceId = 0;
           this.state = GUEST_STATE_CREATED;
         }
       }.bind(this));
     }
 
     this.handleCallback(callback);
   };
 
   attachParams['instanceId'] = viewInstanceId;
@@ skipping 10 matching lines @@
 GuestViewImpl.prototype.createImpl = function(createParams, callback) {
   // Check the current state.
   if (!this.checkState('create')) {
     this.handleCallback(callback);
     return;
   }
 
   // Callback wrapper function to store the guestInstanceId from the
   // createGuest() callback, handle potential creation failure, and advance the
   // queue.
-  var callbackWrapper = function(callback, guestInstanceId) {
-    this.id = guestInstanceId;
+  var callbackWrapper = function(callback, guestInfo) {
+    this.id = guestInfo.id;
+    this.contentWindow =
+        GuestViewInternalNatives.GetContentWindow(guestInfo.contentWindowId);

[lfg, 2015/03/04 19:10:20]

This is ok, but I think it would it be nicer to pass the contentWindow directly
instead of having this extension function.

[Fady Samuel, 2015/03/05 20:56:23]

I'll do that in a separate patch. I don't want to block the Chrome OS folks any
longer.

 
     // Check if creation failed.
     if (this.id === 0) {
       this.state = GUEST_STATE_START;
+      this.contentWindow = null;
     }
 
     ResizeEvent.addListener(this.callOnResize, {instanceId: this.id});
     this.handleCallback(callback);
   };
 
   GuestViewInternal.createGuest(this.viewType,
                                 createParams,
                                 callbackWrapper.bind(this, callback));
 
@@ skipping 37 matching lines @@
   // Check the current state.
   if (!this.checkState('detach')) {
     this.handleCallback(callback);
     return;
   }
 
   GuestViewInternalNatives.DetachGuest(
       this.internalInstanceId,
       this.handleCallback.bind(this, callback));
 
-  this.contentWindow = null;
   this.internalInstanceId = 0;
   this.state = GUEST_STATE_CREATED;
 };
 
 // Internal implementation of setSize().
 GuestViewImpl.prototype.setSizeImpl = function(sizeParams, callback) {
   // Check the current state.
   if (!this.checkState('setSize')) {
     this.handleCallback(callback);
     return;
@@ skipping 58 matching lines @@
 };
 
 // Returns the ID for this guestview.
 GuestView.prototype.getId = function() {
   var internal = privates(this).internal;
   return internal.id;
 };
 
 // Exports
 exports.GuestView = GuestView;