Add checkbox to card unmasking prompt

Add checkbox to card unmasking prompt

- Add pref to make checkbox sticky
- Implement checkbox as per-card, not per-device
- Implement UI on Views

BUG=448587
Committed: https://crrev.com/a1315a2db68f6e4c7d320d646876419a552c9edc
Cr-Commit-Position: refs/heads/master@{#316298}

[Evan Stade, 2015-02-09 23:15:24]

estade@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-02-11 23:55:54]

https://codereview.chromium.org/910043002/diff/20001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right):

https://codereview.chromium.org/910043002/diff/20001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:114: bool
CardUnmaskPromptControllerImpl::ShouldOfferToStoreLocally(
Can we make the store locally default to false on desktop Linux?

Also, we should make sure we have a metric on how many people toggle this. Maybe
it was you who said we have metrics for every pref, but I'm not sure what we
have captures what we want to know (which is how many people toggle this
checkbox).

[Evan Stade, 2015-02-11 23:57:59]

On 2015/02/11 23:55:54, brettw wrote:
>
https://codereview.chromium.org/910043002/diff/20001/chrome/browser/ui/autofi...
> File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right):
> 
>
https://codereview.chromium.org/910043002/diff/20001/chrome/browser/ui/autofi...
> chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:114: bool
> CardUnmaskPromptControllerImpl::ShouldOfferToStoreLocally(
> Can we make the store locally default to false on desktop Linux?

You mean always be false, right? Sure.

> 
> Also, we should make sure we have a metric on how many people toggle this.
Maybe
> it was you who said we have metrics for every pref, but I'm not sure what we
> have captures what we want to know (which is how many people toggle this
> checkbox).

I agree. This is one of many of metrics we should add to the card unmasking
dialog. But as long as we're still iterating heavily on the UI I think it's
prudent to hold off on adding that UMA.

[Evan Stade, 2015-02-13 00:50:16]

uploaded a new patchset which gets rid of the settings checkbox preference. Per
zkoch we're in agreement that making the checkbox per-card and having a clobber
button in settings is the way to go.

Added a TODO for special handling on Linux as it's not clear to me if we've
agreed to not allow saving at all or simply not defaulting to saving.

[Evan Stade, 2015-02-13 20:45:08]

On 2015/02/13 00:50:16, Evan Stade wrote:
> uploaded a new patchset which gets rid of the settings checkbox preference.
Per
> zkoch we're in agreement that making the checkbox per-card and having a
clobber
> button in settings is the way to go.
> 
> Added a TODO for special handling on Linux as it's not clear to me if we've
> agreed to not allow saving at all or simply not defaulting to saving.

ping

[brettw, 2015-02-13 20:57:45]

lgtm

[Evan Stade, 2015-02-13 21:41:16]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-02-13 21:42:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910043002/60001

[commit-bot: I haz the power, 2015-02-13 21:45:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-13 21:46:22]

Patchset 4 (id:??) landed as
https://crrev.com/a1315a2db68f6e4c7d320d646876419a552c9edc
Cr-Commit-Position: refs/heads/master@{#316298}