device/bluetooth:Implement BluetoothMediaEndpointServiceProvider delegate and media-related overrid…

chromeos/dbus/bluetooth_media_transport_client.cc

Index: chromeos/dbus/bluetooth_media_transport_client.cc
diff --git a/chromeos/dbus/bluetooth_media_transport_client.cc b/chromeos/dbus/bluetooth_media_transport_client.cc
index ce9f017348add6115cc1d5e13e55d859f303923e..5847e640568fb38f4af77da6c9fef49be9a6f8cf 100644
--- a/chromeos/dbus/bluetooth_media_transport_client.cc
+++ b/chromeos/dbus/bluetooth_media_transport_client.cc
@@ -25,24 +25,31 @@ const char kAcquire[] = "Acquire";
 const char kTryAcquire[] = "TryAcquire";
 const char kRelease[] = "Release";
 
-// Property names of Media Transport interface.
-const char kDeviceProperty[] = "Device";
-const char kUUIDProperty[] = "UUID";
-const char kCodecProperty[] = "Codec";
-const char kConfigurationProperty[] = "Configuration";
-const char kStateProperty[] = "State";
-const char kDelayProperty[] = "Delay";
-const char kVolumeProperty[] = "Volume";
-
 }  // namespace
 
 namespace chromeos {
 
+// static
 const char BluetoothMediaTransportClient::kNoResponseError[] =
     "org.chromium.Error.NoResponse";
 const char BluetoothMediaTransportClient::kUnexpectedResponse[] =
     "org.chromium.Error.UnexpectedResponse";
 
+// static

[armansito, 2015/02/10 00:17:01]

Why do these need to be class-level constants?

[Miao, 2015/02/10 22:15:21]

Moved kNoResponseError and kUnexpectedResponse back to anonymous namespace.
Since property names are used in endpoint service provider, it makes sense to me
to put property constants under transport namespace, 

+const char BluetoothMediaTransportClient::kDeviceProperty[] = "Device";
+const char BluetoothMediaTransportClient::kUUIDProperty[] = "UUID";
+const char BluetoothMediaTransportClient::kCodecProperty[] = "Codec";
+const char BluetoothMediaTransportClient::kConfigurationProperty[] =
+    "Configuration";
+const char BluetoothMediaTransportClient::kStateProperty[] = "State";
+const char BluetoothMediaTransportClient::kDelayProperty[] = "Delay";
+const char BluetoothMediaTransportClient::kVolumeProperty[] = "Volume";
+
+// static
+const char BluetoothMediaTransportClient::kStateIdle[] = "idle";
+const char BluetoothMediaTransportClient::kStatePending[] = "pending";
+const char BluetoothMediaTransportClient::kStateActive[] = "active";
+
 BluetoothMediaTransportClient::Properties::Properties(
     dbus::ObjectProxy* object_proxy,
     const std::string& interface_name,