device/bluetooth:Implement BluetoothMediaEndpointServiceProvider delegate and media-related overrid…

chromeos/dbus/bluetooth_media_transport_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_BLUETOOTH_MEDIA_TRANSPORT_CLIENT_H_
 #define CHROMEOS_DBUS_BLUETOOTH_MEDIA_TRANSPORT_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 55 matching lines @@
     // from the system.
     virtual void MediaTransportRemoved(const dbus::ObjectPath& object_path) {}
 
     // Called when the Media Transport with object path |object_path| has
     // a change in the value of the property with name |property_name|.
     virtual void MediaTransportPropertyChanged(
         const dbus::ObjectPath& object_path,
         const std::string& property_name) {}
   };
 
+  // Constants used to indicate exceptional error conditions.

[armansito, 2015/02/10 00:17:01]

All of these should go to service_constants.h. though I'm not sure why you need
to declare all of the Property constants here in the header?

[Miao, 2015/02/10 22:15:21]

Comment added! Right, these will go to service_constants.h eventually, but
before that, I think it might be more centralized to put them here. In this
case, I can ensure that the reference in endpoint service provider will be
updated as well. And it makes sense to me that all property constants are under
transport namespace.

+  static const char kNoResponseError[];
+  static const char kUnexpectedResponse[];
+
+  // Constants used for the names of Media Transport's properties.
+  static const char kDeviceProperty[];
+  static const char kUUIDProperty[];
+  static const char kCodecProperty[];
+  static const char kConfigurationProperty[];
+  static const char kStateProperty[];
+  static const char kDelayProperty[];
+  static const char kVolumeProperty[];
+
+  // All possible states of a valid media transport object.
+  static const char kStateIdle[];
+  static const char kStatePending[];
+  static const char kStateActive[];
+
   ~BluetoothMediaTransportClient() override;
 
   // The ErrorCallback is used by media transport API methods to indicate
   // failure. It receives two arguments: the name of the error in |error_name|
   // and an optional message in |error_message|.
   typedef base::Callback<void(const std::string& error_name,
                               const std::string& error_message)> ErrorCallback;
 
   // The AcquireCallback is used by |Acquire| method of media tansport API tp
   // indicate the success of the method.
@@ skipping 22 matching lines @@
                           const AcquireCallback& callback,
                           const ErrorCallback& error_callback) = 0;
 
   // Releases the file descriptor of the transport.
   virtual void Release(const dbus::ObjectPath& object_path,
                        const base::Closure& callback,
                        const ErrorCallback& error_callback) = 0;
 
   static BluetoothMediaTransportClient* Create();
 
-  // Constants used to indicate exceptional error conditions.
-  static const char kNoResponseError[];
-  static const char kUnexpectedResponse[];
-
  protected:
   BluetoothMediaTransportClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BluetoothMediaTransportClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_BLUETOOTH_MEDIA_TRANSPORT_CLIENT_H_