Issue 909973004: Revert of Fix IsWeakObjectInOptimizedCode predicate to also include property cells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 909973004: Revert of Fix IsWeakObjectInOptimizedCode predicate to also include property cells. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
dcarney, ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Fix IsWeakObjectInOptimizedCode predicate to also include property cells. (patchset #1 id:1 of https://codereview.chromium.org/909123002/) Reason for revert: Seems to fail several slow asserts (not on the try server): http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/1841 Original issue's description: > Fix IsWeakObjectInOptimizedCode predicate to also include property cells. > > BUG=v8:3882 > LOG=NO > > Committed: https://crrev.com/f8c404849dd01b538e52d95412225c06a0101808 > Cr-Commit-Position: refs/heads/master@{#26549} TBR=dcarney@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3882 Committed: https://crrev.com/1e4ebb6d5e411ebd4924d4bec25150892bba2576 Cr-Commit-Position: refs/heads/master@{#26551}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/objects-inl.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Fix IsWeakObjectInOptimizedCode predicate to also include property cells.

5 years, 10 months ago (2015-02-10 16:57:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909973004/1

5 years, 10 months ago (2015-02-10 16:58:33 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 16:59:01 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1e4ebb6d5e411ebd4924d4bec25150892bba2576
Cr-Commit-Position: refs/heads/master@{#26551}