Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909883005: Don't put revision as part of the local filename. (Closed)

Created:
5 years, 10 months ago by Adrian Kuegel
Modified:
5 years, 10 months ago
Reviewers:
pgervais
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Don't put revision as part of the local filename. This avoids the problem of having to clean up. Right now, the index_pack file archives are cleaned up by relying on the clobber compile step. This CL also disables the clobber for compilation, because it does not seem to be really necessary for the Codesearch bots. BUG=429684 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294006

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Adrian Kuegel
Philippe, can you please review this CL?
5 years, 10 months ago (2015-02-10 14:26:32 UTC) #2
pgervais
On 2015/02/10 14:26:32, Adrian Kuegel wrote: > Philippe, can you please review this CL? lgtm
5 years, 10 months ago (2015-02-10 14:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909883005/1
5 years, 10 months ago (2015-02-10 14:46:56 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 14:49:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294006

Powered by Google App Engine
This is Rietveld 408576698