[Android] Add IterShell command to iterate over output lines

[Android] Add IterShell command to iterate over output lines

Similar to the existing Logcat, allows to iterate over the lines of
output from long running commands.

BUG=

Committed: https://crrev.com/2eaa5d25137a7317daba1c22c33e28a8f664b168
Cr-Commit-Position: refs/heads/master@{#315347}

[perezju, 2015-02-09 12:21:55]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2015-02-09 14:21:39]

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
build/android/pylib/device/adb_wrapper.py:256: def IterShell(self, command,
timeout):
My concern here is that we don't do the same exit status checking as Shell. What
would it take to do that, and what would the experience be like from the client
side (i.e. would it make sense)?

[perezju, 2015-02-09 16:39:12]

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
build/android/pylib/device/adb_wrapper.py:256: def IterShell(self, command,
timeout):
On 2015/02/09 14:21:38, jbudorick wrote:
> My concern here is that we don't do the same exit status checking as Shell.
What
> would it take to do that, and what would the experience be like from the
client
> side (i.e. would it make sense)?

We had the same discussion regarding Logcat :)

1. We _do_ already check the exit status on the host, the corresponding
cmd_helper command will raise a CalledProcessError if the exit status is
non-zero.

2. There is no reliable way to get the exit status from the device, as we never
know whether we've just read "the last line of output" from the command, or more
lines are to follow.

[jbudorick, 2015-02-09 16:39:59]

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/909833002/diff/1/build/android/pylib/device/a...
build/android/pylib/device/adb_wrapper.py:256: def IterShell(self, command,
timeout):
On 2015/02/09 16:39:12, perezju wrote:
> On 2015/02/09 14:21:38, jbudorick wrote:
> > My concern here is that we don't do the same exit status checking as Shell.
> What
> > would it take to do that, and what would the experience be like from the
> client
> > side (i.e. would it make sense)?
> 
> We had the same discussion regarding Logcat :)

Well, at least I'm consistent :)

> 
> 1. We _do_ already check the exit status on the host, the corresponding
> cmd_helper command will raise a CalledProcessError if the exit status is
> non-zero.
> 
> 2. There is no reliable way to get the exit status from the device, as we
never
> know whether we've just read "the last line of output" from the command, or
more
> lines are to follow.

sgtm

[jbudorick, 2015-02-09 16:50:01]

lgtm

[perezju, 2015-02-09 16:52:51]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2015-02-09 16:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/909833002/1

[commit-bot: I haz the power, 2015-02-09 18:34:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-09 18:35:31]

Patchset 1 (id:??) landed as
https://crrev.com/2eaa5d25137a7317daba1c22c33e28a8f664b168
Cr-Commit-Position: refs/heads/master@{#315347}