Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 909773002: Fix apps sometimes not showing up in the app list search results. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_shadow_border
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix apps sometimes not showing up in the app list search results. This CL fixes an issue with the experimental app list search where the app results would sometimes not show up. This was being caused by the display type not being updated when the result was copied from the mixer, causing recommendation results not to change into tile results. BUG=456060 Committed: https://crrev.com/222650396e5a4a40891362bc7f660b9b73dd3ed4 Cr-Commit-Position: refs/heads/master@{#315264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/app_list/search/mixer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/search_result.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
5 years, 10 months ago (2015-02-09 02:29:25 UTC) #2
Matt Giuca
lgtm
5 years, 10 months ago (2015-02-09 02:43:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909773002/1
5 years, 10 months ago (2015-02-09 03:55:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 04:37:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 04:37:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/222650396e5a4a40891362bc7f660b9b73dd3ed4
Cr-Commit-Position: refs/heads/master@{#315264}

Powered by Google App Engine
This is Rietveld 408576698