Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909763002: Reland: Oilpan: Fix compile failure from r189762 (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland: Oilpan: Fix compile failure from r189762 Fixed non-Oilpan branch compile error. We should use Vector<enum>, not a HeapVector<enum> BUG=445292 TBR=oilpan-reviews Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189769 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189772

Patch Set 1 #

Patch Set 2 : test.cpp / #if ENABLE(OILPAN) to avoid compile error on non-Oilpan builds #

Patch Set 3 : rebased #

Patch Set 4 : Use Vector<CSSTransformValue::TransformOperationType> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/animation/TransformStyleInterpolation.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/TransformStyleInterpolation.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/TransformStyleInterpolationTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-09 01:11:10 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-09 01:18:16 UTC) #3
kouhei (in TOK)
Committed patchset #1 (id:1) manually as 189769 (presubmit successful).
5 years, 10 months ago (2015-02-09 01:18:41 UTC) #4
kouhei (in TOK)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/880743003/ by kouhei@chromium.org. ...
5 years, 10 months ago (2015-02-09 01:29:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909763002/20001
5 years, 10 months ago (2015-02-09 01:51:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/34391) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 10 months ago (2015-02-09 01:52:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909763002/40001
5 years, 10 months ago (2015-02-09 02:01:59 UTC) #12
kouhei (in TOK)
haraken: Would you take a look? The correct fix was to use a Vector<enum>
5 years, 10 months ago (2015-02-09 02:17:57 UTC) #14
haraken
LGTM
5 years, 10 months ago (2015-02-09 02:18:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909763002/60001
5 years, 10 months ago (2015-02-09 02:19:55 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=189772
5 years, 10 months ago (2015-02-09 03:38:04 UTC) #18
Yuta Kitamura
5 years, 10 months ago (2015-02-09 03:47:18 UTC) #20
Message was sent while issue was closed. 
Looks like Oilpan build is still broken:

../../third_party/WebKit/Source/core/animation/TransformStyleInterpolationTest.cpp:26:81:
error: no viable conversion from
'blink::HeapVector<CSSTransformValue::TransformOperationType>' to
'Vector<CSSTransformValue::TransformOperationType>'
        return TransformStyleInterpolation::interpolableValueToTransform(value,
types);
                                                                               
^~~~~
../../third_party/WebKit/Source/wtf/Vector.h:641:9: note: candidate constructor
not viable: no known conversion from
'blink::HeapVector<CSSTransformValue::TransformOperationType>' to 'const
WTF::Vector<blink::CSSTransformValue::TransformOperationType, 0,
WTF::DefaultAllocator> &' for 1st argument
        Vector(const Vector&);
        ^          
../../third_party/WebKit/Source/wtf/Vector.h:649:9: note: candidate constructor
not viable: no known conversion from
'blink::HeapVector<CSSTransformValue::TransformOperationType>' to
'WTF::Vector<blink::CSSTransformValue::TransformOperationType, 0,
WTF::DefaultAllocator> &&' for 1st argument
        Vector(Vector&&);
        ^          
../../third_party/WebKit/Source/core/animation/TransformStyleInterpolation.h:46:144:
note: passing argument to parameter 'types' here
    static PassRefPtrWillBeRawPtr<CSSValue>
interpolableValueToTransform(InterpolableValue*,
Vector<CSSTransformValue::TransformOperationType> types);
                                                                                
                                                              ^
1 error generated. 
ninja: build stopped: subcommand failed.

Powered by Google App Engine
This is Rietveld 408576698