Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909633002: Mac: Enable two finger double-tap smart zoom (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@contentshell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Enable two finger double-tap smart zoom BUG=452592 Committed: https://crrev.com/e69b4fd53dbf2d4c1fdc82de623186d7b21c29fb Cr-Commit-Position: refs/heads/master@{#315214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ccameron
(turns out this needed basically no work) This did need a blink side patch at: ...
5 years, 10 months ago (2015-02-07 01:39:14 UTC) #2
Avi (use Gerrit)
lgtm Well that was easy.
5 years, 10 months ago (2015-02-07 02:15:40 UTC) #3
ccameron
Thanks!
5 years, 10 months ago (2015-02-07 20:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909633002/1
5 years, 10 months ago (2015-02-07 20:01:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 20:50:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e69b4fd53dbf2d4c1fdc82de623186d7b21c29fb Cr-Commit-Position: refs/heads/master@{#315214}
5 years, 10 months ago (2015-02-07 20:51:16 UTC) #8
ccameron
5 years, 10 months ago (2015-02-09 18:06:14 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/859393005/ by ccameron@chromium.org.

The reason for reverting is: This is a suspect in the dramatic increase in crash
rates noted
in crbug.com/456860.

The crashes are on 10.10, so there are no stack traces, so this
is just a guess..

Powered by Google App Engine
This is Rietveld 408576698