Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 90963002: Revert of Base: Remove Receive() from ScopedHandle. (Closed)

Created:
7 years ago by hashimoto
Modified:
7 years ago
CC:
chromium-reviews, amit, yoshiki+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, robertshield, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -228 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M base/process/launch.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/process/launch_win.cc View 8 chunks +9 lines, -17 lines 0 comments Download
M base/win/scoped_handle.h View 2 chunks +26 lines, -0 lines 0 comments Download
A base/win/scoped_handle_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M base/win/scoped_process_information.h View 1 chunk +24 lines, -1 line 0 comments Download
M base/win/scoped_process_information.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M base/win/scoped_process_information_unittest.cc View 8 chunks +14 lines, -21 lines 0 comments Download
M base/win/startup_information_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test_suite.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome_frame/ready_mode/internal/registry_ready_mode_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/test_utils.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/sandbox_win.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/base/net_util_win.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M printing/backend/win_helper.h View 2 chunks +6 lines, -3 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/setup/daemon_installer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/chromoting_module.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 5 chunks +10 lines, -17 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M sandbox/win/src/Wow64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M sandbox/win/src/job_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M sandbox/win/src/policy_target_test.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M sandbox/win/src/process_policy_test.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M sandbox/win/src/restricted_token_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M sandbox/win/src/target_process.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/function_exec_script.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
Created Revert of Base: Remove Receive() from ScopedHandle.
7 years ago (2013-11-27 08:21:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/90963002/1
7 years ago (2013-11-27 08:22:00 UTC) #2
commit-bot: I haz the power
7 years ago (2013-11-27 08:23:34 UTC) #3
Message was sent while issue was closed. 
Change committed as 237541

Powered by Google App Engine
This is Rietveld 408576698