include/core/SkTArray.h - Issue 909583003: Add tests for STArray swap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTArray.h

Issue 909583003: Add tests for STArray swap (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix int/size_t warnings Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTArray.h

diff --git a/include/core/SkTArray.h b/include/core/SkTArray.h

index 9d410c12ea6940dc404ee1563ec325c64d2584d7..dea0e38fecae7e2ac10e0f0b7b517c2847e06364 100644

--- a/include/core/SkTArray.h

+++ b/include/core/SkTArray.h

@@ -273,6 +273,9 @@ public:

/** Swaps the contents of this array with that array. Does a pointer swap if possible,

otherwise copies the T values. */

void swap(SkTArray* that) {

+ if (this == that) {

+ return;

+ }

if (this->fPreAllocMemArray != this->fItemArray &&

that->fPreAllocMemArray != that->fItemArray) {

// If neither is using a preallocated array then just swap.

« no previous file with comments | « no previous file | tests/TArrayTest.cpp » ('j') | no next file with comments »