Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909583003: Add tests for STArray swap (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : fix int/size_t warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M include/core/SkTArray.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/TArrayTest.cpp View 1 2 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
5 years, 10 months ago (2015-02-06 22:55:12 UTC) #2
robertphillips
lgtm
5 years, 10 months ago (2015-02-09 17:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909583003/20001
5 years, 10 months ago (2015-02-09 17:04:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1904)
5 years, 10 months ago (2015-02-09 17:06:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909583003/40001
5 years, 10 months ago (2015-02-11 03:40:24 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 03:47:02 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3632f8473a7842b6f1351694d9b4071a66529224

Powered by Google App Engine
This is Rietveld 408576698