build/common.gypi - Issue 909583002: Revert of Linux: Enable multi-threading with the gold linker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 909583002: Revert of Linux: Enable multi-threading with the gold linker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index c7ba407ae373464720f927141a8eeaa1076c2374..e664be744aa4181cd1eb85c1ba128729d16359f5 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4399,8 +4399,10 @@

# https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36

# Only apply this to the target linker, since the host

# linker might not be gold, but isn't used much anyway.

- '-Wl,--threads',

- '-Wl,--thread-count=4',

+ # TODO(raymes): Disable threading because gold is frequently

+ # crashing on the bots: crbug.com/161942.

+ # '-Wl,--threads',

+ # '-Wl,--thread-count=4',

}],

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »