Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 909483002: [KeyboardEvent]Enable keyboardevent-code.html (Closed)

Created:
5 years, 10 months ago by Habib Virji
Modified:
5 years, 10 months ago
Reviewers:
bokan, Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[KeyboardEvent]Enable keyboardevent-code.html Had disabled tests inorder to land chromium side changes. Chromium side changes have landed in : https://codereview.chromium.org/658183002/. BUG=227231 R=rbyers@chromium.org, bokan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Habib Virji
KeyboardTest was temporarily added in TestExpectations. PTAL
5 years, 10 months ago (2015-02-06 16:17:15 UTC) #1
Rick Byers
lgtm
5 years, 10 months ago (2015-02-07 22:46:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909483002/1
5 years, 10 months ago (2015-02-09 08:23:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/121126) Timed out jobs are ...
5 years, 10 months ago (2015-02-09 10:42:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909483002/1
5 years, 10 months ago (2015-02-11 09:16:48 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 09:17:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189955

Powered by Google App Engine
This is Rietveld 408576698