Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 909473002: Add hash fields to code cache header. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add hash fields to code cache header. R=jochen@chromium.org BUG=chromium:441896 LOG=N Committed: https://crrev.com/7f4d207c8bd510cd1843ff3e30608f0e5290cb1e Cr-Commit-Position: refs/heads/master@{#26490}

Patch Set 1 #

Patch Set 2 : fix test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -24 lines) Patch
M src/flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/serialize.h View 2 chunks +20 lines, -14 lines 0 comments Download
M src/serialize.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M src/version.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yang
5 years, 10 months ago (2015-02-06 14:45:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-06 14:47:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909473002/1
5 years, 10 months ago (2015-02-06 14:48:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909473002/20001
5 years, 10 months ago (2015-02-06 14:59:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 15:20:46 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 15:20:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f4d207c8bd510cd1843ff3e30608f0e5290cb1e
Cr-Commit-Position: refs/heads/master@{#26490}

Powered by Google App Engine
This is Rietveld 408576698