Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 909463003: PreParser / Parser consistency: Make PreParser aware of Zone and AstValueFactory. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParser / Parser consistency: Make PreParser aware of Zone and AstValueFactory. Previously it just had hacks to have NULLs instead of them and pretended to know nothing about Zone. The hacks provide no real benefit (probably historically based on some weird misconception about the relationship between Zone and Isolate), and make it harder for the PreParser to start to know more about variables and scoping. BUG= Committed: https://crrev.com/5c56665059891cbacf43f6efe483582029442f0b Cr-Commit-Position: refs/heads/master@{#26494}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -47 lines) Patch
M src/parser.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/parser.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/preparser.h View 1 14 chunks +21 lines, -24 lines 0 comments Download
M test/cctest/test-parsing.cc View 8 chunks +40 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
rossberg, ptal.
5 years, 10 months ago (2015-02-06 15:00:22 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-06 15:05:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909463003/20001
5 years, 10 months ago (2015-02-06 15:57:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 15:58:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 15:58:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c56665059891cbacf43f6efe483582029442f0b
Cr-Commit-Position: refs/heads/master@{#26494}

Powered by Google App Engine
This is Rietveld 408576698