Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 909353003: cc: Translate filter when texture is larger than quad rect (Closed)

Created:
5 years, 10 months ago by hendrikw
Modified:
5 years, 10 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Translate filter when texture is larger than quad rect The passed in rendered content sits on the bottom-left of the texture, with y=down (or top-right with y=up, makes no difference), but the alpha threshold filter's region sits at top-left with y=down. When the texture is blitted onto the scratch texture through the filter, we normally line up correctly because the texture sizes are the same so it doesn't matter if the textures exist at the top or bottom (because they fill the whole texture). When the texture is larger than the quad rect, the filter no longer lines up with the content because the content sits at the bottom, and the filter is on the top. This will happen when we minimize an application on chromeOS that has an alpha threshold filter (ie hangouts). The fix simply translates the filter by the difference in size between the texture height and quad rect height. There's also a test. Committed: https://crrev.com/bc64aa4314dd27cc4cb9ee4939e722cd81edd73a Cr-Commit-Position: refs/heads/master@{#316035}

Patch Set 1 #

Patch Set 2 : readd tests I killed #

Patch Set 3 : gl -> sw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M cc/output/gl_renderer.cc View 4 chunks +13 lines, -15 lines 0 comments Download
A cc/test/data/enlarged_texture_on_threshold.png View Binary file 0 comments Download
M cc/test/layer_tree_pixel_test.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hendrikw
PTAL
5 years, 10 months ago (2015-02-11 00:54:59 UTC) #2
enne (OOO)
lgtm, thanks for the test!
5 years, 10 months ago (2015-02-12 19:18:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909353003/40001
5 years, 10 months ago (2015-02-12 19:19:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-12 20:05:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 20:06:11 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc64aa4314dd27cc4cb9ee4939e722cd81edd73a
Cr-Commit-Position: refs/heads/master@{#316035}

Powered by Google App Engine
This is Rietveld 408576698