ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html - Issue 909313003: Add cr-checkbox to Chrome

Side by Side Diff: ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html

Issue 909313003: Add cr-checkbox to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css ('K') | « ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css ('k') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js » ('j') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import"

	2 href="chrome://resources/polymer/paper-checkbox/paper-checkbox.html">

	3 <link rel="import"

	4 href="chrome://resources/cr_elements/cr_events/cr_events.html">
	Dan Beam 2015/02/13 21:56:49 that's weird. why are we using _ when polymer use that's weird. why are we using _ when polymer uses -? Dan Beam 2015/02/13 21:56:49 chrome cr cr cr :( chrome cr cr cr :( michaelpg 2015/02/13 23:27:57 cf. paper-checkbox/paper-checkbox.html "cr_events Show quoted text On 2015/02/13 21:56:49, Dan Beam wrote: > chrome cr cr cr :( cf. paper-checkbox/paper-checkbox.html "cr_events/cr_events." is pretty much the* convention in Polymer-land (except the underscore). "chrome://elements/" doesn't imply "chrome elements" any more than "chrome://polymer/" implies "chrome polymer elements". michaelpg 2015/02/13 23:27:57 yeah. We decided to be consistent with the rest of Show quoted text On 2015/02/13 21:56:49, Dan Beam wrote: > that's weird. why are we using _ when polymer uses -? yeah. We decided to be consistent with the rest of Chromium and use underscores everywhere. Having hyphens in the file names but underscores in the directory names is also weird. Dan Beam 2015/02/19 22:47:56 that's repetitive. that's repetitive. it wastes s Show quoted text On 2015/02/13 23:27:57, michaelpg wrote: > On 2015/02/13 21:56:49, Dan Beam wrote: > > chrome cr cr cr :( > > cf. paper-checkbox/paper-checkbox.html that's repetitive. that's repetitive. it wastes space and my time. it wastes space and my time. don't you wish you got those 10s back? don't you wish you got those 10s back? Show quoted text > > "cr_events/cr_events." is pretty much the* convention in Polymer-land (except > the underscore). I'm confused: are we in chrome or polymer land? you just said "we willingly disobey polymer when it comes to - vs _" but we don't when it comes to saving us tons of wrapped lines? Show quoted text > > "chrome://elements/" doesn't imply "chrome elements" any more than > "chrome://polymer/" implies "chrome polymer elements". I don't get what you mean here. English is made up of words strung together. Code is written in/like English. That's why conditional operators are if/else/then, for example, so it reads like logical English. When you glean the English of "chrome://elements", YES is does imply "chrome elements" and "chrome://polymer" does imply "using polymer in Chrome". If we're against writing a new data source for this that's OK I guess, but if the only way these things will ever be loaded is via a URL that starts with chrome:// it seems pretty silly to add 3 more "cr" to it... michaelpg 2015/02/20 01:26:48 My editor cuts this down to 2s... but I acknowledg Show quoted text On 2015/02/19 22:47:56, Dan Beam wrote: > On 2015/02/13 23:27:57, michaelpg wrote: > > On 2015/02/13 21:56:49, Dan Beam wrote: > > > chrome cr cr cr :( > > > > cf. paper-checkbox/paper-checkbox.html > > that's repetitive. that's repetitive. > > it wastes space and my time. it wastes space and my time. > > don't you wish you got those 10s back? don't you wish you got those 10s back? My editor cuts this down to 2s... but I acknowledge that it's repetitive. Show quoted text > > > > > "cr_events/cr_events." is pretty much the* convention in Polymer-land > (except > > the underscore). > > I'm confused: are we in chrome or polymer land? you just said "we willingly > disobey polymer when it comes to - vs _" but we don't when it comes to saving us > tons of wrapped lines? Both. And this is one way we reconcile that. This is the convention that has formed around web components. Just because we're enforcing Chrome style (- vs _) and making use of Chrome facilities (e.g. including with "chrome://" instead of relative paths) doesn't mean we should assume nobody will be interested in using some of our components in their projects. Also, we aren't assuming all files will have the same names as their directories. For instance, "paper-dropdown/paper-dropdown-transition.html" is used by "paper-dropdown/paper-dropdown.html" (yay composition). But it makes it clear that: paper-dropdown/paper-dropdown.html paper-dropdown/paper-dropdown-transition.html both belong to paper-dropdown, while paper-dropdown-menu/paper-dropdown-menu.html belongs to the separate paper-dropdown-menu component. I don't see a great way to encode that information while saving a substantial number of characters... we could leave out "cr_" in the leaf directories. Show quoted text > > > > > "chrome://elements/" doesn't imply "chrome elements" any more than > > "chrome://polymer/" implies "chrome polymer elements". > > I don't get what you mean here. > > English is made up of words strung together. Code is written in/like English. > That's why conditional operators are if/else/then, for example, so it reads like > logical English. > > When you glean the English of "chrome://elements", YES is does imply "chrome > elements" and "chrome://polymer" does imply "using polymer in Chrome". I meant that "using elements in chrome" is not the same as "using custom elements in chrome that are specific to chrome rather than a third party". If "Polymer" can be top-level, Chrome elements should go in a "Chrome" top-level "directory", thus "polymer" and "cr_elements". I don't care much though, so "chrome://elements" is fine with me. Show quoted text > > If we're against writing a new data source for this that's OK I guess, but if > the only way these things will ever be loaded is via a URL that starts with > chrome:// it seems pretty silly to add 3 more "cr" to it... Not sure what you mean, we added this to shared_resources_data_source rather than create a new data source, but it's easily changeable either way.
	5

	6 <polymer-element name="cr-checkbox">

	7 <template>

	8 <link rel="stylesheet" href="cr_checkbox.css">

	9 <cr-events id="events"></cr-events>

	10 <paper-checkbox id="checkbox"

	11 checked?="{{ checked }}" disabled?="{{ disabled }}" label="{{ label }}">

	12 </paper-checkbox>

	13 </template>

	14 <script src="cr_checkbox.js"></script>

	15 </polymer-element>

OLD	NEW