ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html - Issue 909313003: Add cr-checkbox to Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html

Issue 909313003: Add cr-checkbox to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update styling and use underscores Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css ('K') | « ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css ('k') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js » ('j') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import"

	2 href="chrome://resources/polymer/paper-checkbox/paper-checkbox.html">

	3 <link rel="import"

	4 href="chrome://resources/cr_elements/cr_events/cr_events.html">

	5

	6 <polymer-element name="cr-checkbox">

	7 <template>

	8 <link rel="stylesheet" href="cr_checkbox.css">

	9 <cr-events id="events"></cr-events>

	10 <paper-checkbox id="button"
	michaelpg 2015/02/11 02:08:10 label="{{ label }}" label="{{ label }}" Oren Blasberg 2015/02/11 20:12:42 Done. Show quoted text On 2015/02/11 02:08:10, michaelpg wrote: > label="{{ label }}" Done. michaelpg 2015/02/18 00:11:16 Sorry, I've realized this is just a convention fro Show quoted text On 2015/02/11 20:12:42, Oren Blasberg wrote: > On 2015/02/11 02:08:10, michaelpg wrote: > > label="{{ label }}" > > Done. Sorry, I've realized this is just a convention from an older project but isn't followed in Chrome or Polymer. Let's be consistent by avoiding spaces: {{label}} from here on out. Oren Blasberg 2015/02/18 00:17:01 Done. Show quoted text On 2015/02/18 00:11:16, michaelpg wrote: > On 2015/02/11 20:12:42, Oren Blasberg wrote: > > On 2015/02/11 02:08:10, michaelpg wrote: > > > label="{{ label }}" > > > > Done. > > Sorry, I've realized this is just a convention from an older project but isn't > followed in Chrome or Polymer. Let's be consistent by avoiding spaces: {{label}} > from here on out. Done.
	11 checked?="{{ checked }}" disabled?="{{ disabled }}">

	12 </paper-checkbox>

	13 </template>

	14 <script src="cr_checkbox.js"></script>

	15 </polymer-element>

OLD	NEW