ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css - Issue 909313003: Add cr-checkbox to Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.css

Issue 909313003: Add cr-checkbox to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update styling and use underscores Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_settings/md_settings.html ('k') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html » ('j') | ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2015 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 :host {

	6 display: inline-block;

	7 }

	8

	9 paper-checkbox::shadow #ink[checked] {

	10 color: rgb(0, 150, 136);
	Jeremy Klein 2015/02/11 01:55:36 Can we share the color defs somewhere? Can we share the color defs somewhere? Oren Blasberg 2015/02/11 20:12:42 Not sure! Any ideas, Michael or Steven? Note that Show quoted text On 2015/02/11 01:55:36, Jeremy Klein wrote: > Can we share the color defs somewhere? Not sure! Any ideas, Michael or Steven? Note that this styling may change once I update the element to 0.5.4 in a separate cl which I intend to land before this one. stevenjb 2015/02/11 20:35:02 I agree that it would be nice to have something li Show quoted text On 2015/02/11 20:12:42, Oren Blasberg wrote: > On 2015/02/11 01:55:36, Jeremy Klein wrote: > > Can we share the color defs somewhere? > > Not sure! Any ideas, Michael or Steven? > > Note that this styling may change once I update the element to 0.5.4 in a > separate cl which I intend to land before this one. I agree that it would be nice to have something like a cr_elements.css file that all cr_elements share. I have no idea what the best way to implement that would be though, my CSS fu is pretty weak. michaelpg 2015/02/11 20:40:34 Yes! I just discovered <core-style> last night. We Show quoted text On 2015/02/11 20:12:42, Oren Blasberg wrote: > On 2015/02/11 01:55:36, Jeremy Klein wrote: > > Can we share the color defs somewhere? > > Not sure! Any ideas, Michael or Steven? > > Note that this styling may change once I update the element to 0.5.4 in a > separate cl which I intend to land before this one. Yes! I just discovered <core-style> last night. We should come up with a good general-purpose solution using it and then use that for our styling and theming. It has the added advantage of letting other Web UI that use cr-elements easily define their own themes. Here's a simple example: http://pastebin.com/sP2iNMng But we may want to take it a bit further, i.e., define our own <core-style id="cr-themes"> where we specify a bunch of background and foreground colors. Then we can just use those values in cr-checkbox, cr-toggle-button, etc. instead of defining the colors on each individual control. Since we'd still like to have CSS in .css files, maybe we also wrap <core-style> in a <cr-style> element which is capable of importing .css files and applying the templating. Outside the scope of this CL, but take a look and let me know what you think.
	11 }

	12

	13 paper-checkbox::shadow #checkbox.checked {

	14 border-color: rgb(0, 150, 136);

	15 }

OLD	NEW