Properly set ShelfAlignment during login

ash/test/test_session_state_delegate.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_TEST_TEST_SESSION_STATE_DELEGATE_H_
 #define ASH_TEST_TEST_SESSION_STATE_DELEGATE_H_
 
 #include <vector>
 
 #include "ash/session/session_state_delegate.h"
@@ skipping 63 matching lines @@
   // Updates |should_lock_screen_before_suspending_|.
   void SetShouldLockScreenBeforeSuspending(bool should_lock);
 
   // Updates the internal state that indicates whether user adding screen is
   // running now.
   void SetUserAddingScreenRunning(bool user_adding_screen_running);
 
   // Setting non NULL image enables avatar icon.
   void SetUserImage(const gfx::ImageSkia& user_image);
 
+  // Updates the internal state that indicates the state of the session. Does
+  // not notify listeners.
+  void SetSessionState(SessionState session_state);

[tdanderson, 2015/02/11 20:32:35]

The preference for a simple mutator such as this would be to name as void
set_session_state(...) and put the definition in the header file.

[jonross, 2015/02/11 22:17:45]

Done.

+
  private:
   // Whether a session is in progress and there is an active user.
   bool has_active_user_;
 
   // When a user becomes active, the profile and browser UI are not immediately
   // available. Only once this flag becomes |true| is the browser startup
   // complete and both profile and UI are fully available.
   bool active_user_session_started_;
 
   // Whether the screen can be locked. Locking will only actually be allowed
@@ skipping 10 matching lines @@
   bool user_adding_screen_running_;
 
   // The number of users logged in.
   int logged_in_users_;
 
   // The index for the activated user.
   int active_user_index_;
 
   std::vector<MockUserInfo*> user_list_;
 
+  // The current state of the login screen. |session_state_| becomes true before

[tdanderson, 2015/02/11 20:32:35]

Specify what you mean by "becomes true" since |session_state_| is an enum.

[jonross, 2015/02/11 22:17:45]

Done.

+  // the profile and browser UI are available.
+  SessionState session_state_;
+
   DISALLOW_COPY_AND_ASSIGN(TestSessionStateDelegate);
 };
 
 }  // namespace test
 }  // namespace ash
 
 #endif  // ASH_TEST_TEST_SESSION_STATE_DELEGATE_H_