Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909263002: Add Semaphore::TimedWait() (Closed)

Created:
5 years, 10 months ago by Mark Mentovai
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add Semaphore::TimedWait(). This also splits the per-OS Semaphore methods into their own files. TEST=util_test Semaphore.* R=rsesek@chromium.org, scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/10c264cd574f93cf5998adfc5faf14294e25451d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -194 lines) Patch
M util/synchronization/semaphore.h View 1 chunk +13 lines, -0 lines 0 comments Download
D util/synchronization/semaphore.cc View 1 chunk +0 lines, -85 lines 0 comments Download
A + util/synchronization/semaphore_mac.cc View 2 chunks +6 lines, -46 lines 0 comments Download
A + util/synchronization/semaphore_posix.cc View 1 chunk +27 lines, -21 lines 2 comments Download
M util/synchronization/semaphore_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download
A + util/synchronization/semaphore_win.cc View 2 chunks +6 lines, -41 lines 0 comments Download
M util/util.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 10 months ago (2015-02-10 21:29:47 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/909263002/diff/1/util/synchronization/semaphore_posix.cc File util/synchronization/semaphore_posix.cc (left): https://codereview.chromium.org/909263002/diff/1/util/synchronization/semaphore_posix.cc#oldcode15 util/synchronization/semaphore_posix.cc:15: #include "util/misc/clock.h" The find-copies here sucks.
5 years, 10 months ago (2015-02-10 21:57:07 UTC) #3
scottmg
win lgtm
5 years, 10 months ago (2015-02-10 21:59:33 UTC) #4
Mark Mentovai
https://codereview.chromium.org/909263002/diff/1/util/synchronization/semaphore_posix.cc File util/synchronization/semaphore_posix.cc (left): https://codereview.chromium.org/909263002/diff/1/util/synchronization/semaphore_posix.cc#oldcode15 util/synchronization/semaphore_posix.cc:15: #include "util/misc/clock.h" Robert Sesek wrote: > The find-copies here ...
5 years, 10 months ago (2015-02-10 22:01:46 UTC) #5
Mark Mentovai
5 years, 10 months ago (2015-02-10 22:02:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
10c264cd574f93cf5998adfc5faf14294e25451d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698