Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 909233002: Pepper: Always call status_cb in FileDownloader. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: Always call status_cb in FileDownloader. FileDownloader assumed that implementations of blink::WebURLLoader would always call didFail and didFinishLoading, which is not the case. In the cases where didFinishLoading was not called, FileDownloader would never run the status callback, preventing any error reporting from happening. This change deletes the implementation of blink::WebURLLoader in didFail and invokes status_cb, allowing error reporting to work properly, and for memory to be cleaned up. BUG=440180 Committed: https://crrev.com/d800932db8b677c81d8c5d2f0e704168dba03c75 Cr-Commit-Position: refs/heads/master@{#315649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/nacl/renderer/file_downloader.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
teravest
5 years, 10 months ago (2015-02-10 20:00:08 UTC) #2
dmichael (off chromium)
lgtm
5 years, 10 months ago (2015-02-10 21:34:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909233002/1
5 years, 10 months ago (2015-02-10 21:41:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 21:46:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 21:46:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d800932db8b677c81d8c5d2f0e704168dba03c75
Cr-Commit-Position: refs/heads/master@{#315649}

Powered by Google App Engine
This is Rietveld 408576698