Issue 90923005: Remove GR_IMPLEMENTATION define.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90923005: Remove GR_IMPLEMENTATION define. (Closed)

Created:
7 years ago by tfarina

Modified:
7 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove GR_IMPLEMENTATION define. skgputest is built as a static library and thus this define is not needed. If the library was built as shared, then this define would be necessary and used. But it isn't, so we remove it now. BUG=None TEST=None R=bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=12442

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	gyp/gputest.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/90923005/1

7 years ago (2013-12-02 14:15:03 UTC) #3

Message was sent while issue was closed.

Change committed as 12442

Expand Messages | Collapse Messages