Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909183002: win/aura: Remove some more non-aura code for Windows. (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-shell_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/aura: Remove some more non-aura code for Windows. This removes all the uses of USE_AURA ifdefs from the _win.cc files (and some additional removal of dead code). BUG=none R=mkwst@chromium.org, sky@chromium.org, thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/da8b9b72a31951a1a2b68a4e60c5719b52443404

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -181 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime_win.cc View 1 3 chunks +6 lines, -38 lines 0 comments Download
M chrome/browser/metro_utils/metro_chrome_win.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/metro_utils/metro_chrome_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/crash/app/hard_error_handler_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M printing/printing_context_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/gfx/path_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sadrul
sky@chromium.org: Please review changes in chrome/browser/ and ui cpu@chromium.org: Please review changes in components/ content/ ...
5 years, 10 months ago (2015-02-10 17:18:45 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-10 18:05:28 UTC) #3
sadrul
cpu@: ping
5 years, 10 months ago (2015-02-11 18:57:42 UTC) #4
sadrul
+thestig@ for alternate component/crash/ and printing/ owner +mkwst@ for alternate content/shell owner
5 years, 10 months ago (2015-02-13 06:36:17 UTC) #6
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-13 07:05:42 UTC) #7
Mike West
content/shell LGTM.
5 years, 10 months ago (2015-02-13 14:25:54 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/da8b9b72a31951a1a2b68a4e60c5719b52443404 Cr-Commit-Position: refs/heads/master@{#316231}
5 years, 10 months ago (2015-02-13 17:13:46 UTC) #9
sadrul
5 years, 10 months ago (2015-02-13 17:13:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
da8b9b72a31951a1a2b68a4e60c5719b52443404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698