Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909143004: Add support for starting an extension print job to print preview (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for starting an extension print job to print preview This only implements web UI part; print_preview_handler returns an error for all issued jobs. BUG=408772 Committed: https://crrev.com/90c6d73f3b28a38933dbabda15bd2ed25cbb1c5e Cr-Commit-Position: refs/heads/master@{#315925}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : vitaly's feedback #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 3 chunks +2 lines, -5 lines 2 comments Download
M chrome/browser/resources/print_preview/print_header.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 chunks +22 lines, -0 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tbarzic
5 years, 10 months ago (2015-02-11 22:24:19 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/909143004/diff/40001/chrome/browser/resources/print_preview/native_layer.js File chrome/browser/resources/print_preview/native_layer.js (right): https://codereview.chromium.org/909143004/diff/40001/chrome/browser/resources/print_preview/native_layer.js#newcode381 chrome/browser/resources/print_preview/native_layer.js:381: if (destination.isPrivet) { destination.isPrivet || destination.isExtension https://codereview.chromium.org/909143004/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File ...
5 years, 10 months ago (2015-02-11 22:39:26 UTC) #3
tbarzic
https://codereview.chromium.org/909143004/diff/40001/chrome/browser/resources/print_preview/native_layer.js File chrome/browser/resources/print_preview/native_layer.js (right): https://codereview.chromium.org/909143004/diff/40001/chrome/browser/resources/print_preview/native_layer.js#newcode381 chrome/browser/resources/print_preview/native_layer.js:381: if (destination.isPrivet) { On 2015/02/11 22:39:26, Vitaly Buka wrote: ...
5 years, 10 months ago (2015-02-11 22:48:18 UTC) #5
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/909143004/diff/60001/chrome/browser/resources/print_preview/native_layer.js File chrome/browser/resources/print_preview/native_layer.js (right): https://codereview.chromium.org/909143004/diff/60001/chrome/browser/resources/print_preview/native_layer.js#newcode350 chrome/browser/resources/print_preview/native_layer.js:350: 'printWithExtension': destination.isExtension, It feels like printWith... are mutually ...
5 years, 10 months ago (2015-02-12 02:23:17 UTC) #6
tbarzic
https://codereview.chromium.org/909143004/diff/60001/chrome/browser/resources/print_preview/native_layer.js File chrome/browser/resources/print_preview/native_layer.js (right): https://codereview.chromium.org/909143004/diff/60001/chrome/browser/resources/print_preview/native_layer.js#newcode350 chrome/browser/resources/print_preview/native_layer.js:350: 'printWithExtension': destination.isExtension, On 2015/02/12 02:23:17, Aleksey Shlyapnikov wrote: > ...
5 years, 10 months ago (2015-02-12 02:42:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909143004/60001
5 years, 10 months ago (2015-02-12 02:43:11 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-12 03:41:06 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 03:42:28 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/90c6d73f3b28a38933dbabda15bd2ed25cbb1c5e
Cr-Commit-Position: refs/heads/master@{#315925}

Powered by Google App Engine
This is Rietveld 408576698