Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: src/objects-inl.h

Issue 909123002: Fix IsWeakObjectInOptimizedCode predicate to also include property cells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 65e789f0328dd826f8db53a07b4672f623b84571..14392d1d6143d13691377a6856bb29e8303c42f3 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5242,7 +5242,9 @@ bool Code::IsWeakObjectInOptimizedCode(Object* object) {
return Map::cast(object)->CanTransition() &&
FLAG_weak_embedded_maps_in_optimized_code;
}
- if (object->IsCell()) object = Cell::cast(object)->value();
+ if (object->IsCell() || object->IsPropertyCell()) {
+ object = Cell::cast(object)->value();
+ }
if (object->IsJSObject()) {
return FLAG_weak_embedded_objects_in_optimized_code;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698