Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909123002: Fix IsWeakObjectInOptimizedCode predicate to also include property cells. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix IsWeakObjectInOptimizedCode predicate to also include property cells. BUG=v8:3882 LOG=NO Committed: https://crrev.com/f8c404849dd01b538e52d95412225c06a0101808 Cr-Commit-Position: refs/heads/master@{#26549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-10 15:39:25 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-10 15:39:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909123002/1
5 years, 10 months ago (2015-02-10 15:40:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 16:09:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8c404849dd01b538e52d95412225c06a0101808 Cr-Commit-Position: refs/heads/master@{#26549}
5 years, 10 months ago (2015-02-10 16:09:39 UTC) #7
Michael Achenbach
5 years, 10 months ago (2015-02-10 16:57:44 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/909973004/ by machenbach@chromium.org.

The reason for reverting is: Seems to fail several slow asserts (not on the try
server):
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/....

Powered by Google App Engine
This is Rietveld 408576698