Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 909013008: Move SubstituteData and UniqueIdentifier to core/fetch/ from core/loader/ (Closed)

Created:
5 years, 10 months ago by Nate Chapin
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move SubstituteData and UniqueIdentifier to core/fetch/ from core/loader/ UniqueIdenitifier has no dependencies at all, and SubstituteData depends only on platform/ and wtf/. They should be at least as low-level as core/fetch. BUG=458222 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -175 lines) Patch
M Source/core/core.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/fetch/SubstituteData.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/fetch/UniqueIdentifier.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/fetch/UniqueIdentifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoadRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/loader/SubstituteData.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/loader/UniqueIdentifier.h View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/core/loader/UniqueIdentifier.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nate Chapin
5 years, 10 months ago (2015-02-12 20:59:09 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-12 21:12:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909013008/1
5 years, 10 months ago (2015-02-12 21:15:52 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 21:23:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190079

Powered by Google App Engine
This is Rietveld 408576698