Issue 908973002: Add includes back to channel_info.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 908973002: Add includes back to channel_info.h. (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add includes back to channel_info.h. (They were removed in ea8e9591f3d0e9a0240b54db3cb7b3446dd0e444.) MSVS doesn't like not having them, at least sometimes. I'm not sure why. TBR=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f87aeadbda22441b7d469e596f7bd7d0d73e2a8

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	mojo/edk/system/channel_info.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Committed patchset #1 (id:1) manually as 9f87aeadbda22441b7d469e596f7bd7d0d73e2a8 (presubmit successful).

5 years, 10 months ago (2015-02-10 00:07:06 UTC) #2

yzshen1

5 years, 10 months ago (2015-02-10 00:07:37 UTC) #3

Message was sent while issue was closed.

On 2015/02/10 00:07:06, viettrungluu wrote:
> Committed patchset #1 (id:1) manually as
> 9f87aeadbda22441b7d469e596f7bd7d0d73e2a8 (presubmit successful).

LGTM

Expand Messages | Collapse Messages